Plugin EP data transfer and Stream support. #25254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TODO: Flesh out for usage on ORT API boundary for model inputs/outputs including usage involving interop.
skottmckay
requested review from
adrianlizarraga and
edgchen1
and removed request for
adrianlizarraga
Contributor
Author
Add CopyTensors to public API and ability to create OrtSyncStream to use with the copy.
|
Will this PR allow streaming the models from disk, thereby reducing device memory usage? |
Can be used with CopyTensors with the cudaStream_t from the OrtSyncStream being passed in via provider options (existing setup). Updated CopyTensors to take a single stream. User can make multiple calls if they need to use multiple streams.
Data copy test with CUDA works, including passing in the cudaStream_t to the session via provider options. Follow up PR will make it possible to provide an OrtSyncStream to the Run instead.
skottmckay
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
skottmckay
commented
Jul 9, 2025
skottmckay
commented
Jul 9, 2025
skottmckay
changed the title
Check return status in data copy unit test.
``` error: The difference between expected[i] and results[i] is 8.8930130004882812e-05, which exceeds 1e-5, where expected[i] evaluates to -1.2537282705307007, results[i] evaluates to -1.2536393404006958, and 1e-5 evaluates to 1.0000000000000001e-05. ```
…reateSyncStreamForDevice. An EP implementation may be dependent on the per-session settings or need to create a per-session allocator (WebGPU does) so we need to either provide the OrtEp this way, or add create allocator/stream functions to OrtEp. Add new function implementations to QNN OrtEpFactory.
skottmckay
added a commit
that referenced
this pull request
Jul 14, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
Adds support for asynchronous data transfer and stream synchronization for plugin execution providers (EPs), including new C API extensions, environment/allocator updates, and example implementations.
- Introduce
OrtSyncStream,OrtSyncNotification, andCopyTensorsAPIs in the C API and internalOrtApis. - Extend
Environmentto register/unregister plugin EP data transfer, allocators (including arena wrap), and manage sync streams. - Provide example stream/notification implementations for CUDA and the plugin EP test library, plus new tests in
test_data_copy.cc.
Reviewed Changes
Copilot reviewed 42 out of 42 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| onnxruntime/test/shared_lib/test_data_copy.cc | Add tests for plugin EP data copy and optional stream use |
| onnxruntime/core/session/ort_apis.h | Extend C API with SyncStream, SyncNotification, and CopyTensors |
| onnxruntime/core/framework/plugin_ep_stream.* | Implement plugin EP stream & notification wrapper classes |
| onnxruntime/core/session/environment.cc | Register plugin EP data transfers and manage shared allocators |
| onnxruntime/core/session/ep_factory_internal.* | Refactor EP factory to support stream creation & data transfer |
Comments suppressed due to low confidence (1)
onnxruntime/test/autoep/library/ep_data_transfer.cc:66
- [nitpick] There's a typo in the comment ('teh'). Consider correcting the spelling or removing this outdated commented line.
// the implementation for a 'real' EP would be something along these lines.
jywu-msft
reviewed
Jul 16, 2025
pgonegandla
reviewed
Jul 16, 2025
Add functions to create allocator and sync stream to OrtEp struct so an EP can create per-session instances if it chooses to. Needed for CUDA (sync stream needs to read session option for graph capture) and webgpu (session allocator uses different memory type to shared allocator).
gaugarg-nv
reviewed
Jul 17, 2025
adrianlizarraga
approved these changes
Jul 19, 2025
jywu-msft
approved these changes
Jul 19, 2025
Contributor
|
Hi there! We haven't cut the release branch for this version yet, so I'm removing the |
qti-yuduo
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Aug 8, 2025
### Description <!-- Describe your changes. --> Plugin EP data transfer and Stream support. Add the ability for a plugin EP to provide an IDataTransfer implementation and an OrtSyncStream implementation to do async data copy outside of an inference session. Example usage added for CUDA EP. Caveat: Support for providing the OrtSyncStream from the data copy to Session.Run will be a follow up PR. For the CUDA EP we can pass in the native cudaStream_t from the OrtSyncStream used for the data copy to the Run via CUDA EP provider options. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
sanketkaleoss
pushed a commit
to sanketkaleoss/onnxruntime
that referenced
this pull request
Aug 11, 2025
### Description <!-- Describe your changes. --> Plugin EP data transfer and Stream support. Add the ability for a plugin EP to provide an IDataTransfer implementation and an OrtSyncStream implementation to do async data copy outside of an inference session. Example usage added for CUDA EP. Caveat: Support for providing the OrtSyncStream from the data copy to Session.Run will be a follow up PR. For the CUDA EP we can pass in the native cudaStream_t from the OrtSyncStream used for the data copy to the Run via CUDA EP provider options. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Plugin EP data transfer and Stream support.
Add the ability for a plugin EP to provide an IDataTransfer implementation and an OrtSyncStream implementation to do async data copy outside of an inference session.
Example usage added for CUDA EP.
Caveat: Support for providing the OrtSyncStream from the data copy to Session.Run will be a follow up PR. For the CUDA EP we can pass in the native cudaStream_t from the OrtSyncStream used for the data copy to the Run via CUDA EP provider options.
Motivation and Context