Skip to content

[QNN EP] Fix error messages being logged as VERBOSE instead of ERROR #24931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tianleiwu merged 11 commits into from
Jan 23, 2026
Merged

[QNN EP] Fix error messages being logged as VERBOSE instead of ERROR #24931

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
593bdfa
Initial plan for issue
Copilot Jun 2, 2025
467abdd
Fix QNN error messages being logged as VERBOSE instead of ERROR
Copilot Jun 2, 2025
9d63cd8
Address code review feedback: eliminate duplicate code and make MapQN…
Copilot Jun 2, 2025
9969c9a
Merge branch 'main' into copilot/fix-24876
yuslepukhin Jan 12, 2026
f005b5a
Update onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc
yuslepukhin Jan 12, 2026
653e021
Update onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc
yuslepukhin Jan 12, 2026
9ac878c
Remove stray proto
Jan 15, 2026
42c028c
Merge branch 'main' into copilot/fix-24876
Jan 15, 2026
2d67d6b
Fix log level mapping
Jan 16, 2026
96c1470
Merge branch 'main' into copilot/fix-24876
Jan 16, 2026
9a9b309
CI failure
Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 36 additions & 2 deletions onnxruntime/core/providers/qnn/builder/qnn_backend_manager.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,6 @@ void QnnLogging(const char* format,
QnnLog_Level_t level,
uint64_t timestamp,
va_list argument_parameter) {
ORT_UNUSED_PARAMETER(level);
ORT_UNUSED_PARAMETER(timestamp);

if (!::onnxruntime::logging::LoggingManager::HasDefaultLogger()) {
Expand All @@ -417,7 +416,26 @@ void QnnLogging(const char* format,
}

const auto& logger = ::onnxruntime::logging::LoggingManager::DefaultLogger();
const auto severity = ::onnxruntime::logging::Severity::kVERBOSE;

Comment thread
yuslepukhin marked this conversation as resolved.
Outdated
// Map QNN log level to ORT severity
Comment thread
yuslepukhin marked this conversation as resolved.
logging::Severity severity;
Comment thread
yuslepukhin marked this conversation as resolved.
Outdated
switch (level) {
case QNN_LOG_LEVEL_VERBOSE:
case QNN_LOG_LEVEL_DEBUG:
severity = logging::Severity::kVERBOSE;
break;
case QNN_LOG_LEVEL_INFO:
severity = logging::Severity::kINFO;
break;
case QNN_LOG_LEVEL_WARN:
severity = logging::Severity::kWARNING;
break;
case QNN_LOG_LEVEL_ERROR:
default:
severity = logging::Severity::kERROR;
break;
}

Comment thread
yuslepukhin marked this conversation as resolved.
Outdated
const auto data_type = ::onnxruntime::logging::DataType::SYSTEM;
Comment thread
yuslepukhin marked this conversation as resolved.
Outdated

if (logger.OutputIsEnabled(severity, data_type)) {
Expand Down Expand Up @@ -491,6 +509,22 @@ QnnLog_Level_t QnnBackendManager::MapOrtSeverityToQNNLogLevel(logging::Severity
}
}

logging::Severity QnnBackendManager::MapQNNLogLevelToOrtSeverity(QnnLog_Level_t qnn_log_level) {
// Map QNN log level to ORT log severity
switch (qnn_log_level) {
case QNN_LOG_LEVEL_VERBOSE:
case QNN_LOG_LEVEL_DEBUG:
return logging::Severity::kVERBOSE;
case QNN_LOG_LEVEL_INFO:
return logging::Severity::kINFO;
case QNN_LOG_LEVEL_WARN:
return logging::Severity::kWARNING;
case QNN_LOG_LEVEL_ERROR:
default:
return logging::Severity::kERROR;
}
}

Status QnnBackendManager::ResetQnnLogLevel(std::optional<logging::Severity> ort_log_level) {
std::lock_guard<std::recursive_mutex> lock(logger_recursive_mutex_);
if (!backend_setup_completed_ || logger_ == nullptr) {
Expand Down
1 change: 1 addition & 0 deletions onnxruntime/core/providers/qnn/builder/qnn_backend_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,7 @@ class QnnBackendManager : public std::enable_shared_from_this<QnnBackendManager>
const char* QnnProfileErrorToString(QnnProfile_Error_t error);
std::string QnnErrorHandleToString(Qnn_ErrorHandle_t error);
QnnLog_Level_t MapOrtSeverityToQNNLogLevel(logging::Severity ort_log_level);
logging::Severity MapQNNLogLevelToOrtSeverity(QnnLog_Level_t qnn_log_level);
Comment thread
yuslepukhin marked this conversation as resolved.
Outdated
#ifdef _WIN32
void LogQnnProfileEventAsTraceLogging(
uint64_t timestamp,
Expand Down