Fix attention QK linkage error #24134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Looks reasonable |
Member
|
The linkage error is due to the fact that Multihead attention code attempts to indirectly instantiate CopyQK with <float, float> but that does not exists |
tianleiwu
approved these changes
Mar 22, 2025
tianleiwu
reviewed
Mar 22, 2025
zhaoxul-qti
pushed a commit
to CodeLinaro/onnxruntime
that referenced
this pull request
Apr 17, 2025
### Description This PR moves the CUDA memcpy for the QK output when type `T` is equal to type `QK` from `attention_impl.cu` into `attention_qk.cu`. ### Motivation and Context This PR fixes a linkage error when type `T` and type `QK` are the same in `attention_qk.cu`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the CUDA memcpy for the QK output when type
Tis equal to typeQKfromattention_impl.cuintoattention_qk.cu.Motivation and Context
This PR fixes a linkage error when type
Tand typeQKare the same inattention_qk.cu.