[js/web] improve workaround for bundlers #23902
Merged
+100
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! Testing this now! 🔥 |
xenova
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
I tested with Transformers.js & vite and it works well!
Before:
vite v6.2.0 building for production...
✓ 30 modules transformed.
dist/index.html 0.46 kB │ gzip: 0.29 kB
dist/assets/ort.bundle.min-D2-GKZ-g.mjs 392.96 kB
dist/assets/ort-wasm-simd-threaded.jsep-Y7jqkEt_.wasm 23,013.11 kB │ gzip: 5,533.76 kB
dist/assets/index-BaiKPFAq.css 1.20 kB │ gzip: 0.62 kB
dist/assets/index-Dg6HUVTj.js 812.49 kB │ gzip: 216.72 kB
After:
vite v6.2.0 building for production...
✓ 30 modules transformed.
dist/index.html 0.46 kB │ gzip: 0.30 kB
dist/assets/ort-wasm-simd-threaded.jsep-eo8oczH3.wasm 21,959.93 kB │ gzip: 5,201.83 kB
dist/assets/index-BaiKPFAq.css 1.20 kB │ gzip: 0.62 kB
dist/assets/index-DDX6gZv3.js 816.14 kB │ gzip: 217.45 kB
@fs-eire @guschmue, once merged, could we put out a dev build too? 🤗
guschmue
approved these changes
Mar 5, 2025
guschmue
pushed a commit
that referenced
this pull request
Mar 6, 2025
### Description This PR improves the workaround for bundlers in onnxruntime-web. Specifically, the following changes have been made: - Use [this workaround](xenova@9c50aa2) as suggested by @xenova in huggingface/transformers.js#1161 (comment) - Use `url > "file:" && url < "file;"` instead of `url.startsWith("file:")` to allow minifiers to remove dead code correctly. This change allows to remove unnecessary dependencies of file parsed from `new URL("ort.bundle.min.js", import.meta.url)` in Vite, and optimize code like `if("file://filepath.js".startsWith("file:")) {do_sth1(); } else {do_sth2();}` into `do_sth1()` for webpack/terser usages. Resolves huggingface/transformers.js#1161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the workaround for bundlers in onnxruntime-web. Specifically, the following changes have been made:
Use this workaround as suggested by @xenova in fix package export huggingface/transformers.js#1161 (comment)
Use
url > "file:" && url < "file;"instead ofurl.startsWith("file:")to allow minifiers to remove dead code correctly.This change allows to remove unnecessary dependencies of file parsed from
new URL("ort.bundle.min.js", import.meta.url)in Vite, and optimize code likeif("file://filepath.js".startsWith("file:")) {do_sth1(); } else {do_sth2();}intodo_sth1()for webpack/terser usages.Resolves huggingface/transformers.js#1161