Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPU: Remove deprecated subgroups-f16 from WebGPU native and JS EP #23898

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

WebGPU: Remove deprecated subgroups-f16 from WebGPU native and JS EP #23898

wants to merge 1 commit into from
+2 −46

Conversation

jiangzhaoming
Copy link
Contributor

This PR removes the deprecated subgroups-f16 from WebGPU native and JS EP, and also remove the unused deviceInfo in WebGPU JS EP.

@jiangzhaoming
WebGPU: Remove deprecated subgroups-f16 from WebGPU native and JS EP
2512085 
And also remove the unused deviceInfo in WebGPU JS EP.
@jiangzhaoming
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@jiangzhaoming
Copy link
Contributor Author

@qjia7 Please take a look, thanks!

@jiangzhaoming
Copy link
Contributor Author

I have validated that subgroups-f16 WebGPU feature and subgroups_f16 WGSL extension is deprecated and not required for using f16 in subgroups in Chrome stable M134.

qjia7
qjia7 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@qjia7 qjia7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
@fs-eire @guschmue Please take a look, thanks.

@qjia7 qjia7 requested review from fs-eire and guschmue March 5, 2025 10:33
@fs-eire
Copy link
Contributor

fs-eire commented Mar 5, 2025

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Win_TRT_Minimal_CUDA_Test_CI,Linux CPU CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Mar 5, 2025

/azp run Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline,Android CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Mar 5, 2025

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 6 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@fs-eire
Copy link
Contributor

fs-eire commented Mar 5, 2025

need to run formatter/linter

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qjia7 qjia7 qjia7 approved these changes

@fs-eire fs-eire fs-eire approved these changes

@guschmue guschmue Awaiting requested review from guschmue

Assignees
No one assigned
Labels
ep:WebGPU ort-web webgpu provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jiangzhaoming @fs-eire @qjia7 @guschmue