Rework the native library usage so that a pre-built ORT native package can be easily used #22345
+447
−575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e can be easily used. The same native libraries were being included by almost every project, but the native library is only needed to run tests. Due to the multiple inclusions attempting to use a pre-built package was clashing with any local builds that were available. Create a helper file to include either a local built of a pre-built package and include that in the two test projects. Cleanup various miscellaous things.
skottmckay
commented
Oct 8, 2024
carzh
reviewed
Oct 25, 2024
csharp/test/Microsoft.ML.OnnxRuntime.Tests.Common/NativeLibraryInclude.props
Show resolved
Hide resolved
carzh
approved these changes
Oct 30, 2024
…rpNativeLibUsage_PR
snnn
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
By coincidence your this PR fixed another problem I am investigating: when running the tests in csharp\test\Microsoft.ML.OnnxRuntime.Tests.Common\InferenceTest.cs when DML is enabled, actually we are using the operating system's DirectML.dll which is very old. We should use the one downloaded during our build.
|
Thanks for your fix. I will merge your PR now to unblock the engineering system team's DML integration work. |
yf711
pushed a commit
that referenced
this pull request
Nov 8, 2024
…e can be easily used (#22345) ### Description The local build of the native library was being included by almost every project, but is only needed to run tests. Due to the multiple inclusions attempting to use a pre-built package was clashing with any local builds that were available. Create a helper file to include either a local built of a pre-built package and include that in the two test projects. Cleanup various miscellaous things. ### Motivation and Context Create setup to simplify running on-device tests with the nuget packages.
yf711
pushed a commit
that referenced
this pull request
Nov 11, 2024
…e can be easily used (#22345) ### Description The local build of the native library was being included by almost every project, but is only needed to run tests. Due to the multiple inclusions attempting to use a pre-built package was clashing with any local builds that were available. Create a helper file to include either a local built of a pre-built package and include that in the two test projects. Cleanup various miscellaous things. ### Motivation and Context Create setup to simplify running on-device tests with the nuget packages.
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this pull request
Nov 19, 2024
…e can be easily used (microsoft#22345) ### Description The local build of the native library was being included by almost every project, but is only needed to run tests. Due to the multiple inclusions attempting to use a pre-built package was clashing with any local builds that were available. Create a helper file to include either a local built of a pre-built package and include that in the two test projects. Cleanup various miscellaous things. ### Motivation and Context Create setup to simplify running on-device tests with the nuget packages.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The local build of the native library was being included by almost every project, but is only needed to run tests. Due to the multiple inclusions attempting to use a pre-built package was clashing with any local builds that were available.
Create a helper file to include either a local built of a pre-built package and include that in the two test projects.
Cleanup various miscellaous things.
Motivation and Context
Create setup to simplify running on-device tests with the nuget packages.