Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[js/rn] Support load external data #20090

Merged
merged 2 commits into from
Apr 5, 2024
Merged

[js/rn] Support load external data #20090

merged 2 commits into from
Apr 5, 2024

Conversation

hans00
Copy link
Contributor

@hans00 hans00 commented Mar 26, 2024

Description

Support load external data by passing local model path

Motivation and Context

@fs-eire fs-eire requested a review from YUNQIUGUO March 26, 2024 20:20
YUNQIUGUO
YUNQIUGUO previously approved these changes Mar 26, 2024
View reviewed changes
@fs-eire
Copy link
Contributor

fs-eire commented Mar 27, 2024

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Mar 27, 2024

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Android CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Mar 27, 2024

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@fs-eire
Copy link
Contributor

fs-eire commented Mar 27, 2024

please fix the format error

@fs-eire
Copy link
Contributor

fs-eire commented Mar 28, 2024

/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Mar 28, 2024

/azp run Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-amd-gpu-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Android CI Pipeline

@fs-eire
Copy link
Contributor

fs-eire commented Mar 28, 2024

/azp run iOS CI Pipeline,ONNX Runtime React Native CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

1 similar comment
@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 10 pipeline(s).

@hans00 hans00 requested a review from YUNQIUGUO April 1, 2024 18:29
@microsoft microsoft deleted a comment from azure-pipelines bot Apr 3, 2024
@YUNQIUGUO
Copy link
Contributor

/azp run Linux GPU CI Pipeline ONNX Runtime React Native CI Pipeline

@azure-pipelines Azure Pipelines
Copy link

No pipelines are associated with this pull request.

@fs-eire
Copy link
Contributor

fs-eire commented Apr 3, 2024

I mannually triggered a re-run for the failed job on the previous task because the artifact is expired.

@tianleiwu
Copy link
Contributor

/azp run ONNX Runtime Web CI Pipeline,Linux GPU CI Pipeline,orttraining-amd-gpu-ci-pipeline

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@tianleiwu tianleiwu merged commit 6abfb6b into microsoft:main Apr 5, 2024
78 of 82 checks passed
TedThemistokleous pushed a commit to TedThemistokleous/onnxruntime that referenced this pull request May 7, 2024
@hans00
[js/rn] Support load external data (microsoft#20090)
f5e0ef6 
Support load external data by passing local model path
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@hans00
[js/rn] Support load external data (microsoft#20090)
bab47e5 
Support load external data by passing local model path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YUNQIUGUO YUNQIUGUO YUNQIUGUO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hans00 @fs-eire @YUNQIUGUO @tianleiwu