Skip to content

Conversation

@ashku-ms
Copy link
Contributor

This change implements the maxunpool operator for CPU.

@ashku-ms ashku-ms requested a review from a team as a code owner December 14, 2018 05:47
@pranavsharma
Copy link
Contributor

/AzurePipelines run all

souptc pushed a commit that referenced this pull request Dec 17, 2018
…new OpTester class

The logical ops were the first ones to mix types, so the existing SimpleFloatTest wasn't enough. Plus I thought I could simplify things further.

In OpTester, it generates the input & output defs automatically based on the inputs & outputs set. See "OpTester test("Equal");" in the change for an example. It should be self explanatory.

I didn't convert all of the existing tests over yet, as this is an incremental change. I will convert and remove the old code in a future change.

Related work items: #177
@ashku-ms ashku-ms merged commit a19b624 into microsoft:master Dec 20, 2018
@ashku-ms ashku-ms deleted the ashku/Maxunpool branch December 20, 2018 17:44
TedThemistokleous added a commit to TedThemistokleous/onnxruntime that referenced this pull request Oct 2, 2025
…osoft#177)

Running into a case where the amount of names being larger than inputs from the MIGraphX program causes us to go out of bounds and try to index outputs that don't exist. This leads to undefined/broken behavior (faults)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants