Resize and EP specific transpose optimization updates #17664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skottmckay
requested review from
HectorSVC,
adrianlizarraga,
askhade and
edgchen1
Merged
…izeTransposeOptimization
…izeTransposeOptimization
edgchen1
reviewed
Sep 25, 2023
edgchen1
previously approved these changes
Sep 25, 2023
adrianlizarraga
previously approved these changes
Sep 26, 2023
skottmckay
dismissed stale reviews from adrianlizarraga and edgchen1
via
515c52d
Co-authored-by: Edward Chen <[email protected]>
…izeTransposeOptimization
…://github.com/microsoft/onnxruntime into skottmckay/ImproveResizeTransposeOptimization
onnxruntime/core/optimizer/transpose_optimization/ort_transpose_optimization.cc
Show resolved
Hide resolved
adrianlizarraga
approved these changes
Sep 28, 2023
skottmckay
deleted the
skottmckay/ImproveResizeTransposeOptimization
branch
kleiti
pushed a commit
to kleiti/onnxruntime
that referenced
this pull request
Mar 22, 2024
### Description <!-- Describe your changes. --> - Treat Resize as layout sensitive by default - whilst the ONNX spec does not specify a layout, EPs tend to implement only one - add second usage in L2 of TransposeOptimizer to plugin the ability to push a Transpose through a Resize assigned to the CPU EP - Allow EP specific logic for changes the ops considered to be layout sensitive to be plugged in - expected usage is for microsoft#17200 ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> Finish simplifying/clarifying transpose optimization and layout transformation that was proposed in microsoft#15552. This PR along with microsoft#17618 should complete the changes. --------- Co-authored-by: Edward Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Finish simplifying/clarifying transpose optimization and layout transformation that was proposed in #15552. This PR along with #17618 should complete the changes.