Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onnx_test_runner: shutdown threadpool at exit #161

Closed
wants to merge 1 commit into from

Conversation

snnn
Copy link
Member

@snnn snnn commented Dec 12, 2018

Shutdown threadpool at exit

@snnn snnn requested a review from a team as a code owner December 12, 2018 23:59
@RyanUnderhill
Copy link
Member

This is just for Linux?

@snnn
Copy link
Member Author

snnn commented Dec 13, 2018

This is just for Linux?

Yes. Windows doesn't need this. It is using the default thread pool which can't be shutdown. And this is the reason why your are seeing memory leaking, which I think it's just a false alarm.

souptc pushed a commit that referenced this pull request Dec 17, 2018
LRN cpu kernel impl.

Related work items: #161
@snnn snnn closed this Jan 15, 2019
@snnn snnn deleted the snnn/shutdown_thread_pool branch January 15, 2019 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants