Remove Win8 support #15219
Merged
Remove Win8 support #15219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snnn
commented
Mar 25, 2023
| CREATEFILE2_EXTENDED_PARAMETERS param; | ||
| memset(¶m, 0, sizeof(param)); | ||
| param.dwSize = sizeof(CREATEFILE2_EXTENDED_PARAMETERS); | ||
| param.dwFileFlags = FILE_FLAG_BACKUP_SEMANTICS; |
There was a problem hiding this comment.
The old code forgot to set this FILE_FLAG_BACKUP_SEMANTICS flag, so it didn't work if the input path is a directory!
jchen351
approved these changes
Mar 27, 2023
PeixuanZuo
pushed a commit
that referenced
this pull request
Mar 29, 2023
### Description Remove Win8 support since it is EOL. See https://learn.microsoft.com/en-us/lifecycle/announcements/windows-8-1-end-support-january-2023 ### Motivation and Context Simplify code.
|
We still have several customers who use Windows 7 or 8, unfortunately. We would also like them to upgrade but so far we have not been successful. |
skottmckay
added a commit
that referenced
this pull request
Jun 8, 2023
…15219 removed a check that it was available, making it a hard dependency. When it's not available the dll load fails with a 'procedure not found' error. Add back the check.
skottmckay
added a commit
that referenced
this pull request
Jun 9, 2023
### Description <!-- Describe your changes. --> SetThreadDescription isn't available in an Azure App Service sandbox. #15219 removed a check that it was available, making it a hard dependency. When it's not available the dll load fails with a 'procedure not found' error. Add back the check. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> #15375 - although note this has nothing to do with the original issue. This is just for #15375 (comment)
snnn
pushed a commit
that referenced
this pull request
Jun 15, 2023
### Description <!-- Describe your changes. --> SetThreadDescription isn't available in an Azure App Service sandbox. #15219 removed a check that it was available, making it a hard dependency. When it's not available the dll load fails with a 'procedure not found' error. Add back the check. ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> #15375 - although note this has nothing to do with the original issue. This is just for #15375 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove Win8 support since it is EOL.
See https://learn.microsoft.com/en-us/lifecycle/announcements/windows-8-1-end-support-january-2023
Motivation and Context
Simplify code. And when I was doing this, I found a bug in #4651 .