You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the creation of zero length tensors via the buffer path (the array path with zero length arrays still throws as the validation logic to check it's not ragged would require more intrusive revision), and allows the tensor.getValue() method to return a Java multidimensional array with a zero dimension. Also added a test for the creation and extraction behaviour.
Motivation and Context
The Python interface can return zero length tensors (e.g. if object detection doesn't find any objects), and before this PR in Java calling tensor.getValue() throws an exception with a confusing error message. Fixes#7270 & #15107.
@yuslepukhin would you mind taking a look at this? It fixes a behaviour difference between Java & Python which people run into when deploying object recognition systems that don't find any objects in the supplied image.
@yuslepukhin would you mind taking a look at this? It fixes a behaviour difference between Java & Python which people run into when deploying object recognition systems that don't find any objects in the supplied image.
I think you mean scalar tensors. They are not zero length. They do have empty shapes, however, the length is 1. Correct me if I am wrong.
@yuslepukhin would you mind taking a look at this? It fixes a behaviour difference between Java & Python which people run into when deploying object recognition systems that don't find any objects in the supplied image.
I think you mean scalar tensors. They are not zero length. They do have empty shapes, however, the length is 1. Correct me if I am wrong.
No, those are already supported in the Java API. This specifically deals with the case where a tensor is used with a variable dimension that happens to be zero. For example if the output shape is[num_objects, 4] but the specific output tensor is of size [0, 4] because no objects were detected. The current behaviour in the Java API is to throw an exception with a confusing error message when tensor.getValue() is called, the new behaviour is to return a float[0][4] (or similar), which is closer to what Python does, which is return a numpy array with shape [0,4].
/azp run MacOS CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline, ONNX Runtime Web CI Pipeline, onnxruntime-python-checks-ci-pipeline
/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, Linux QNN CI Pipeline
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows the creation of zero length tensors via the buffer path (the array path with zero length arrays still throws as the validation logic to check it's not ragged would require more intrusive revision), and allows the
tensor.getValue()method to return a Java multidimensional array with a zero dimension. Also added a test for the creation and extraction behaviour.Motivation and Context
The Python interface can return zero length tensors (e.g. if object detection doesn't find any objects), and before this PR in Java calling
tensor.getValue()throws an exception with a confusing error message. Fixes #7270 & #15107.