MKLDNN Sum and Batch Normalizaton kernels #115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@pranavsharma how to kick off CI pipeline? |
jywu-msft
reviewed
Dec 6, 2018
Member
jywu-msft
left a comment
jywu-msft
left a comment
There was a problem hiding this comment.
can you sync master? I think there are changes here that aren't yours.
Contributor
Author
|
@jywu-msft I noticed it. I am having problems to sync master.
|
Member
|
did you fetch upstream to pull in the latest and then merge? |
Contributor
Author
|
yes |
Contributor
Author
|
@jywu-msft I now only see my changes. Can you please take a look? |
yufenglee
reviewed
Dec 6, 2018
pranavsharma
reviewed
Dec 7, 2018
pranavsharma
reviewed
Dec 7, 2018
pranavsharma
reviewed
Dec 7, 2018
pranavsharma
reviewed
Dec 7, 2018
pranavsharma
reviewed
Dec 7, 2018
pranavsharma
approved these changes
Dec 8, 2018
snnn
pushed a commit
that referenced
this pull request
Dec 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sum Kernel
Modified base
class Sum_6incore\providers\cpu\math\element_wise_ops.hRemoved finalfor mkldnn to fallback to cpu computation.
Batch Norm Kernel
Modified base class
onnxruntime::BatchNormin filecore\providers\cpu\nn\batch_norm.hRemoved final and made epsilon_ as protected member.