Move floatToHalf from onnxruntime_util.lib to onnxruntime_framework.lib #10508
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Actually, instead of making onnxruntime_framework depends on eigen, maybe we should move the MLFloat16::ToFloat() function to somewhere else. @edgchen1 Eigen is used for implementing CPU kernels. We should make the core framework less dependent on Eigen. I will close this PR and discuss it with @edgchen1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Move floatToHalf from onnxruntime_util.lib to onnxruntime_framework.lib, to break the circular dependency between the two libs.
BTW, I'm surprised GCC didn't post an error on this. See https://github.com/microsoft/onnxruntime/blob/master/docs/cmake_guideline.md#static-library-order-matters about why it shouldn't work.
Motivation and Context