-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Build] ORT with Memory Profiling feature results in broken build #16124
Labels
build
build issues; typically submitted using template
platform:windows
issues related to the Windows platform
Comments
jslhcl
added a commit
that referenced
this issue
May 31, 2023
### Description <!-- Describe your changes. --> This PR is to fix the build break when onnxruntime_ENABLE_MEMORY_PROFILE is on ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> This PR is to fix the build break when onnxruntime_ENABLE_MEMORY_PROFILE is on. It fixes this issue #16124 Co-authored-by: Lei Cao <[email protected]>
Closing. Memory Profiling now works again with the fix. We tested on GPU since that is what is there by default, but in code it can be changed to CPU and that works as well. |
snnn
added a commit
that referenced
this issue
Jun 1, 2023
### Description 1. Add a Memory Profiling build job 2. Remove no absl build job since the feature will be removed 3. Simplify post-merge-jobs.yml by unifying the pool names ### Motivation and Context To catch build errors in #16124
snnn
pushed a commit
that referenced
this issue
Jun 15, 2023
### Description <!-- Describe your changes. --> This PR is to fix the build break when onnxruntime_ENABLE_MEMORY_PROFILE is on ### Motivation and Context <!-- - Why is this change required? What problem does it solve? - If it fixes an open issue, please link to the issue here. --> This PR is to fix the build break when onnxruntime_ENABLE_MEMORY_PROFILE is on. It fixes this issue #16124 Co-authored-by: Lei Cao <[email protected]>
Fixed in ONNX Runtime 1.15.1 release. |
FYI Memory profiling was added in #5658 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
build issues; typically submitted using template
platform:windows
issues related to the Windows platform
Describe the issue
Dev build with onnxruntime_ENABLE_MEMORY_PROFILE results in broken build
Urgency
Needed to investigate memory usage of ONNX and models used in AI inferencing
Target platform
Windows amd64 cpu
Build script
build.bat --config RelWithDebInfo --build_shared_lib --parallel --cmake_generator "Visual Studio 17 2022" --skip_tests --cmake_extra_defines onnxruntime_ENABLE_MEMORY_PROFILE=ON
Error / output
E:\src\onnxruntime\onnxruntime\core\framework\execution_frame.cc(423,15): error C2039: 'name': is not a member of 'OrtDevice' [E:\src\onnxruntime\build\Windows\Re
E:\src\onnxruntime\onnxruntime\core\framework\execution_frame.cc(423,15): error C2672: 'std::_Hash<std::_Umap_traits<_Kty,_Ty,std::_Uhash_compare<_Kty,_Hasher,_Ke
E:\src\onnxruntime\onnxruntime\core\framework\execution_frame.cc(431,64): error C2039: 'name': is not a member of 'OrtDevice' [E:\src\onnxruntime\build\Windows\Re
E:\src\onnxruntime\onnxruntime\core\framework\execution_frame.cc(612,55): error C2039: 'name': is not a member of 'OrtDevice' [E:\src\onnxruntime\build\Windows\Re
E:\src\onnxruntime\onnxruntime\core\framework\memory_info.cc(44,13): error C2679: binary '=': no operator found which takes a right-hand operand of type 'const Or
E:\src\onnxruntime\onnxruntime\core\framework\memory_info.cc(58,31): error C2665: 'std::map<OrtMemoryInfo,std::map<onnxruntime::MemoryInfo::MapType,onnxruntime::M
Visual Studio Version
Visual Studio 2022
GCC / Compiler Version
No response
The text was updated successfully, but these errors were encountered: