-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C, C++, and Python API for Adapters (Multi-LoRA and others) #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baijumeswani
force-pushed
the
baijumeswani/multi-lora
branch
from
October 2, 2024 06:56
1ac15e1
to
d02e011
Compare
baijumeswani
force-pushed
the
baijumeswani/multi-lora
branch
from
October 7, 2024 18:30
d02e011
to
5d21f0b
Compare
baijumeswani
changed the title
C API for Adapters (Multi-LoRA and others)
C, C++, and Python API for Adapters (Multi-LoRA and others)
Oct 8, 2024
natke
reviewed
Oct 9, 2024
pranavsharma
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the interest of time, let's resolve the ref counting issues later as they don't affect the public APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request introduces a way to apply adapters to a model with onnxruntime-genai. It leverages onnxruntime API changes from microsoft/onnxruntime#22046 and allows users to load, apply, and unload adapters as needed.
This pull-request adds the C, C++ and the Python API. Other language bindings will follow soon.
Example usage:
C++
Python