Add upper bounds to dependencies - #2221
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens runtime validation in the Generator constructor to reject invalid generation/search parameters early, preventing out-of-range settings from reaching backend search implementations.
Changes:
- Enforce
batch_sizeto be within[1, 256]and update the thrown error message accordingly. - Add constructor-time validation that
num_beamsis within an allowed range, with a descriptive error message.
kunal-vaishnavi
approved these changes
Jun 30, 2026
tianleiwu
pushed a commit
that referenced
this pull request
Jul 11, 2026
This pull request adds stricter validation for generation parameters in the `Generator` constructor to prevent invalid or out-of-bounds values. Parameter validation improvements: * Enforced that `batch_size` must be between 1 and 256, updating the error message to reflect the valid range. * Added a new check to ensure `num_beams` is also between 1 and 256, throwing a descriptive error if the value is out of bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds stricter validation for generation parameters in the
Generatorconstructor to prevent invalid or out-of-bounds values.Parameter validation improvements:
batch_sizemust be between 1 and 256, updating the error message to reflect the valid range.num_beamsis also between 1 and 256, throwing a descriptive error if the value is out of bounds.