Skip to content

Add validation for input data #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akshay Sonawane (apsonawane) merged 4 commits into from
Jun 30, 2026
Merged

Add validation for input data #2220

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ce70fa4
Add validation
apsonawane Jun 11, 2026
428e357
Address comments
apsonawane Jun 11, 2026
ecb0ef1
Address comments
apsonawane Jun 12, 2026
1ca4ee9
Merge branch 'main' into asonawane/beamsearch
apsonawane Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/beam_search_scorer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ BeamSearchScorer::BeamSearchScorer(const GeneratorParams& parameters)
next_beam_indices_ = parameters.p_device->Allocate<int32_t>(batch_beam_size);

// Space to store intermediate sequence
size_t const per_beam = (max_length_ * (max_length_ + 1)) / 2;
size_t const per_beam = (static_cast<size_t>(max_length_) * (static_cast<size_t>(max_length_) + 1)) / 2;
hypothesis_buffer_ = device.Allocate<int32_t>(batch_beam_size * per_beam);
Comment thread
apsonawane marked this conversation as resolved.

memset(next_beam_scores_.Span().data(), 0, next_beam_scores_.Span().size_bytes());
Expand Down
8 changes: 4 additions & 4 deletions src/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1111,7 +1111,7 @@ struct Model_Element : JSON::Element {
} else if (name == "vocab_size") {
v_.vocab_size = static_cast<int>(JSON::Get<double>(value));
} else if (name == "context_length") {
v_.context_length = static_cast<int>(JSON::Get<double>(value));
v_.context_length = SafeDoubleToInt(JSON::Get<double>(value), name);
Comment thread
apsonawane marked this conversation as resolved.
} else if (name == "pad_token_id") {
Comment thread
apsonawane marked this conversation as resolved.
v_.pad_token_id = static_cast<int>(JSON::Get<double>(value));
} else if (name == "eos_token_id") {
Expand Down Expand Up @@ -1248,11 +1248,11 @@ struct Search_Element : JSON::Element {
if (name == "min_length") {
v_.min_length = static_cast<int>(JSON::Get<double>(value));
} else if (name == "max_length") {
v_.max_length = static_cast<int>(JSON::Get<double>(value));
v_.max_length = SafeDoubleToInt(JSON::Get<double>(value), name);
Comment thread
apsonawane marked this conversation as resolved.
} else if (name == "batch_size") {
v_.batch_size = static_cast<int>(JSON::Get<double>(value));
v_.batch_size = SafeDoubleToInt(JSON::Get<double>(value), name);
} else if (name == "num_beams") {
Comment thread
apsonawane marked this conversation as resolved.
v_.num_beams = static_cast<int>(JSON::Get<double>(value));
v_.num_beams = SafeDoubleToInt(JSON::Get<double>(value), name);
} else if (name == "num_return_sequences") {
v_.num_return_sequences = static_cast<int>(JSON::Get<double>(value));
} else if (name == "top_k") {
Expand Down
Loading