Add grid dimension validation - #2219
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR strengthens robustness in the Qwen VL vision pipeline by adding validation around QwenVisionPipeline::CalculateWindowIndex, which computes window reordering indices from image_grid_thw-derived dimensions.
Changes:
- Added input validation for non-positive grid dimensions.
- Introduced upper bounds intended to prevent excessive allocations / overflows.
- Refactored allocation and indexing to use precomputed padded dimensions and a single
alloc_size.
apsonawane
enabled auto-merge (squash)
June 11, 2026 23:06
kunal-vaishnavi
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds important validation and safety checks to the
QwenVisionPipeline::CalculateWindowIndexfunction insrc/models/qwen_vl_vision.cpp. The changes are focused on improving robustness by validating input dimensions and preventing integer overflows during memory allocation.Input Validation and Safety Improvements:
grid_t,grid_h,grid_w) are positive; throws an exception if not.