Skip to content

Clean up base constructor in model builder - #2192

Merged
kunal-vaishnavi merged 22 commits into
mainfrom
kvaishnavi/clean-up-init
Jun 4, 2026
Merged

Clean up base constructor in model builder#2192
kunal-vaishnavi merged 22 commits into
mainfrom
kvaishnavi/clean-up-init

Add subfolder to Python wheel

a1f862b
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / CodeQL completed Jun 3, 2026 in 3s

1 configuration not found

Warning: Code scanning may not have found all the alerts introduced by this pull request, because 1 configuration present on refs/heads/main was not found:

API upload

  • ❓  <default>

New alerts in code changed by this pull request

  • 1 warning

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 267 in src/python/py/models/builders/base.py

See this annotation in the file changed.

Code scanning / CodeQL

`__init__` method calls overridden method Warning

This call to
Model.make_rope_init
in an initialization method is overridden by
LlamaModel.make_rope_init
.
This call to
Model.make_rope_init
in an initialization method is overridden by
Phi3MiniLongRoPEModel.make_rope_init
.