Update Copilot instructions for reviewing model builder - #2164
Merged
Baiju Meswani (baijumeswani) merged 1 commit intoMay 14, 2026
Merged
Conversation
kunal-vaishnavi
enabled auto-merge (squash)
May 14, 2026 17:16
Baiju Meswani (baijumeswani)
approved these changes
May 14, 2026
Baiju Meswani (baijumeswani)
disabled auto-merge
May 14, 2026 17:18
Baiju Meswani (baijumeswani)
deleted the
kvaishnavi/update-copilot-model-builder-review
branch
May 14, 2026 17:18
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the Python Model Builder Copilot review instructions to highlight a specific code-style preference when inserting nodes, aiming to improve consistency across ongoing model-builder PR reviews.
Changes:
- Adds a guideline recommending
self.make_op_nameas the preferred wrapper when inserting nodes.
|
|
||
| Read both documents to understand the intended usage, supported models, design principles, and architectural constraints before suggesting or reviewing any code changes in this area. | ||
|
|
||
| When a node is inserted into the model, prefer using `self.make_op_name` as the wrapper method for `self.make_node` + `self.make_value` calls. |
This was referenced Aug 1, 2026
Bump Microsoft.ML.OnnxRuntimeGenAI and Microsoft.ML.OnnxRuntimeGenAI.Managed
trackdubllc/Trackdub#53
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an extra line to the Copilot review instructions for the model builder.
Motivation and Context
There are several open PRs for the model builder. This is one of the code style items that should be looked for during a PR review.