Fix memory leaks - #2153
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a memory leak in the C++ zero-overhead wrapper (src/ort_genai.h) by ensuring temporary OgaStringArray allocations created for batch prompt processing are released.
Changes:
- Added
OgaDestroyStringArray(strs)after batch multi-modal processing calls for images, audios, and images+audios prompt APIs. - Prevented
OgaStringArrayfrom leaking on the success path of these helper functions.
baijumeswani
force-pushed
the
skottmckay/FixMemoryLeak
branch
from
May 15, 2026 20:52
898d26e to
bffe6f0
Compare
baijumeswani
force-pushed
the
skottmckay/FixMemoryLeak
branch
from
May 15, 2026 21:07
216dd8e to
517a38f
Compare
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
kunal-vaishnavi
approved these changes
May 15, 2026
baijumeswani
enabled auto-merge (squash)
May 15, 2026 22:47
kunal-vaishnavi
disabled auto-merge
May 18, 2026 08:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Memory leak showed up in FL testing.