Skip to content

Add onStageComplete #2074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Akshay Sonawane (apsonawane) merged 2 commits into from
Apr 23, 2026
Merged

Add onStageComplete #2074

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9808c98
Add onStageComplete
apsonawane Apr 7, 2026
634f307
Remove unused next_tokens argument
apsonawane Apr 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/models/decoder_only_pipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,6 +344,10 @@ void DecoderOnlyPipelineState::RunPipeline(int total_length, DeviceSpan<int32_t>
}
}
}

// Notify derived classes that this pipeline stage has completed.
// This allows e.g. Qwen VL to inject vision embeddings after the embeddings stage.
OnStageComplete(pipeline_state->id_, next_tokens);
}
}

Expand Down
Loading