Skip to content

Fix CUDA build with MSVC by enabling /Zc:preprocessor for nvcc host compilation on VS 16.5 or greater #2054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunal-vaishnavi merged 5 commits into from
May 18, 2026
Merged

Fix CUDA build with MSVC by enabling /Zc:preprocessor for nvcc host compilation on VS 16.5 or greater #2054

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e682d6b
Fix CUDA build with MSVC by enabling /Zc:preprocessor for nvcc host c…
Apr 1, 2026
0b76951
Update CMakeLists.txt
nsubaru Apr 1, 2026
335f51c
Merge branch 'main' into fix/msvc-build-failure-on-version-greter-the…
May 12, 2026
17c633a
Merge branch 'fix/msvc-build-failure-on-version-greter-then-16.5-due-…
May 12, 2026
5762dff
Merge branch 'main' into fix/msvc-build-failure-on-version-greter-the…
May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,13 @@ if((USE_CUDA OR USE_TRT_RTX) AND CMAKE_CUDA_COMPILER)
$<$<COMPILE_LANGUAGE:CUDA>:-Wno-deprecated-gpu-targets>
$<$<AND:$<COMPILE_LANGUAGE:CUDA>,$<CXX_COMPILER_ID:MSVC>>:-Xcompiler=/wd4996>
)

# nvcc compiles CUDA code with cl.exe, so we need to pass the /Zc:preprocessor option to avoid compilation errors
if(WIN32 AND MSVC AND MSVC_VERSION GREATER_EQUAL 1925)
add_compile_options(
$<$<AND:$<COMPILE_LANGUAGE:CUDA>,$<CXX_COMPILER_ID:MSVC>>:-Xcompiler=/Zc:preprocessor>
)
endif()

if(WIN32)
add_library(onnxruntime-genai-cuda SHARED ${generator_cudalib_srcs} "${GENERATORS_ROOT}/dll/onnxruntime-genai.rc")
Expand Down
Loading