Skip to content

Fix: Win32 build failure when paths contain spaces #2053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunal-vaishnavi merged 3 commits into from
May 18, 2026
Merged

Fix: Win32 build failure when paths contain spaces #2053

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
612c385
Fix: Win32 build failure when paths contain spaces
Apr 1, 2026
2db446d
Merge branch 'main' into fix/win32-build-failure-when-path-contain-sp…
May 12, 2026
f511b86
Merge branch 'main' into fix/win32-build-failure-when-path-contain-sp…
May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ if((USE_CUDA OR USE_TRT_RTX) AND CMAKE_CUDA_COMPILER)
elseif(UNIX)
set_property(TARGET onnxruntime-genai-cuda APPEND_STRING PROPERTY LINK_FLAGS "-Xlinker --version-script=${GENERATORS_ROOT}/cuda/version_script.lds -Xlinker --gc-sections")
elseif(WIN32)
set_property(TARGET onnxruntime-genai-cuda APPEND_STRING PROPERTY LINK_FLAGS "-DEF:${GENERATORS_ROOT}/cuda/symbols.def")
set_property(TARGET onnxruntime-genai-cuda APPEND_STRING PROPERTY LINK_FLAGS "-DEF:\"${GENERATORS_ROOT}/cuda/symbols.def\"")
Comment thread
nsubaru marked this conversation as resolved.
else()
message(FATAL_ERROR "${target} unknown platform, need to specify shared library exports for it")
endif()
Expand Down
Loading