Rename NemotronCacheConfig to NemotronConfig and add blank penalty to the decoder - #2042
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Nemotron Speech (RNNT streaming ASR) model integration by renaming the model config struct and wiring a new blank_penalty parameter from genai_config.json into the RNNT decoding step.
Changes:
- Renamed
NemotronCacheConfigtoNemotronConfigacross the Nemotron speech and streaming processor code. - Added
blank_penaltytoConfig::Model, parsed it from JSON, and propagated it intoNemotronConfig. - Applied
blank_penaltyduring joiner-logits argmax to discourage (or encourage) blank emissions.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/models/nemotron_streaming_processor.h | Switched getters/member from cache_config_ to nemotron_config_. |
| src/models/nemotron_streaming_processor.cpp | Uses nemotron_config_ throughout for streaming mel + cache behavior. |
| src/models/nemotron_speech.h | Renamed config struct to NemotronConfig and added blank_penalty. |
| src/models/nemotron_speech.cpp | Propagates blank_penalty from config and applies it during decoding argmax. |
| src/config.h | Added blank_penalty field under streaming ASR / RNNT parameters. |
| src/config.cpp | Added JSON parsing for model.blank_penalty. |
kunal-vaishnavi
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.