Support Visual Studio 18 2026 build - #2017
Conversation
Co-authored-by: xiaofeihan1 <107654914+xiaofeihan1@users.noreply.github.com>
|
Copilot I think you don't need to change cmake/presets/CMakeWinConfigPresets.json which might change default behaviro. Only add support vs 2026 but still using 2022 by default |
Co-authored-by: xiaofeihan1 <107654914+xiaofeihan1@users.noreply.github.com>
Reverted the |
There was a problem hiding this comment.
Pull request overview
Adds an additional CMake generator option to the repo’s top-level build script to allow building with Visual Studio 18 (2026), while keeping Visual Studio 17 (2022) as the default on Windows.
Changes:
- Extend
build.py --cmake_generatorallowed choices to include"Visual Studio 18 2026". - Preserve the existing default generator (
"Visual Studio 17 2022"on Windows).
|
Copilot can you update this PR by merging main into it? |
Summary
Adds support for building with Visual Studio 18 2026 (CMake generator
"Visual Studio 18 2026"). The default generator remains"Visual Studio 17 2022".Changes
build.py: Added"Visual Studio 18 2026"to the--cmake_generatorargument choices list, alongside the existing"Visual Studio 17 2022"option. The default remains"Visual Studio 17 2022".Usage
Using the build script:
python build.py --cmake_generator "Visual Studio 18 2026"💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.