Skip to content

Support Visual Studio 18 2026 build - #2017

Merged
Baiju Meswani (baijumeswani) merged 3 commits into
mainfrom
copilot/add-visual-studio-18-2026-support
May 18, 2026
Merged

Support Visual Studio 18 2026 build#2017
Baiju Meswani (baijumeswani) merged 3 commits into
mainfrom
copilot/add-visual-studio-18-2026-support

Conversation

Copilot AI commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds support for building with Visual Studio 18 2026 (CMake generator "Visual Studio 18 2026"). The default generator remains "Visual Studio 17 2022".

Changes

  • build.py: Added "Visual Studio 18 2026" to the --cmake_generator argument choices list, alongside the existing "Visual Studio 17 2022" option. The default remains "Visual Studio 17 2022".

Usage

Using the build script:

python build.py --cmake_generator "Visual Studio 18 2026"

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI and others added 2 commits March 11, 2026 06:21
Co-authored-by: xiaofeihan1 <107654914+xiaofeihan1@users.noreply.github.com>
@xiaofeihan1

Copy link
Copy Markdown
Contributor

Copilot I think you don't need to change cmake/presets/CMakeWinConfigPresets.json which might change default behaviro. Only add support vs 2026 but still using 2022 by default

Co-authored-by: xiaofeihan1 <107654914+xiaofeihan1@users.noreply.github.com>

Copilot AI commented Mar 11, 2026

Copy link
Copy Markdown
Contributor Author

Copilot I think you don't need to change cmake/presets/CMakeWinConfigPresets.json which might change default behaviro. Only add support vs 2026 but still using 2022 by default

Reverted the CMakeWinConfigPresets.json change — VS 2022 remains the default. The only change now is adding "Visual Studio 18 2026" as a choice in build.py. See commit e2eb9f8.

@xiaofeihan1
Xiaofei Han (xiaofeihan1) marked this pull request as ready for review April 24, 2026 02:18
Copilot AI review requested due to automatic review settings April 24, 2026 02:18
@xiaofeihan1
Xiaofei Han (xiaofeihan1) marked this pull request as draft April 24, 2026 02:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an additional CMake generator option to the repo’s top-level build script to allow building with Visual Studio 18 (2026), while keeping Visual Studio 17 (2022) as the default on Windows.

Changes:

  • Extend build.py --cmake_generator allowed choices to include "Visual Studio 18 2026".
  • Preserve the existing default generator ("Visual Studio 17 2022" on Windows).

@baijumeswani

Copy link
Copy Markdown
Collaborator

Copilot can you update this PR by merging main into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants