-
Notifications
You must be signed in to change notification settings - Fork 291
Update handling EOS token id detection #1925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
40 commits
Select commit
Hold shift + click to select a range
7df4aa7
Add IsMaxLength API
kunal-vaishnavi 9d41ed9
Add HitEOS and HitMaxLength APIs
kunal-vaishnavi b12e260
Add language bindings and update unit tests
kunal-vaishnavi 795719d
Update README
kunal-vaishnavi 4a13b80
Fix Java build and initialize pointers
kunal-vaishnavi 3165142
Add checks for beam search
kunal-vaishnavi a3299aa
Merge branch 'main' into kvaishnavi/fix-early-return
kunal-vaishnavi 74c4fac
Remove HitEOS from examples since GetNextTokens works in streaming mode
kunal-vaishnavi 5cf30ae
Add C++ API for GetNextTokens and use in examples
kunal-vaishnavi f96fa85
Introduce TokenCount API instead
kunal-vaishnavi 06f6703
Add GetSearchNumber and GetSearchBool APIs
kunal-vaishnavi d18fe38
Undo accidental change
kunal-vaishnavi 93b6279
Fix return types in Java bindings
kunal-vaishnavi 87ef255
Add missing value call
kunal-vaishnavi d5c51a1
Update return type for Objective-C binding of TokenCount
kunal-vaishnavi deac1b1
Add missing return in Java binding of TokenCount
kunal-vaishnavi 606b494
Fix names of APIs called in C API
kunal-vaishnavi 279eaa2
Add missing const references
kunal-vaishnavi 67487c2
Add changes suggested by C++ linter
kunal-vaishnavi 09fc909
Add some more missing const references
kunal-vaishnavi 8d9fda8
Change how Python binding is done
kunal-vaishnavi a95ac69
Use fullname for pybind dict
kunal-vaishnavi d70baa1
Define TokenCount binding with PyGenerator instead of OgaGenerator
kunal-vaishnavi d160ea0
Add changes suggested by C++ linter
kunal-vaishnavi 36d6e3d
Move ApplyChatTemplate into one line and ignore local C++ linter
kunal-vaishnavi ebe9eaf
Add assertions in unit tests for new APIs
kunal-vaishnavi e4bc169
Fix language binding API names
kunal-vaishnavi 5ca18c7
Update how chunk size is obtained
kunal-vaishnavi 6f6c0b0
Fix max length in assertion
kunal-vaishnavi 1c2ed9d
Remove default values from Java bindings
kunal-vaishnavi fb1f8d5
Fix C API call inside Java API
kunal-vaishnavi 2197b1a
Fix value in assert
kunal-vaishnavi 735b73a
Merge branch 'main' into kvaishnavi/fix-early-return
kunal-vaishnavi 7afeb51
Remove breaking changes documentation from README
kunal-vaishnavi 3b990df
Construct vector in return statement
kunal-vaishnavi 27d42b5
Make changes based on PR feedback
kunal-vaishnavi 4461a6e
Add back missing definition
kunal-vaishnavi 6913f9f
Pin transformers to be before v5
kunal-vaishnavi 5a668f3
Cast token count from size_t to int in C#
kunal-vaishnavi c2a45e9
Simplify getting chunk size value
kunal-vaishnavi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.