Fix guidance usage in continuous decoding#1870
Merged
Merged
Conversation
apsonawane
approved these changes
Nov 14, 2025
kunal-vaishnavi
added a commit
that referenced
this pull request
Nov 14, 2025
### Description This PR resets the guidance logits processor when generation is completed and fixes the last action that occurred. ### Motivation and Context This PR fixes a bug with providing grammars in multi-turn conversations where the generator is re-used.
Merged
baijumeswani
added a commit
that referenced
this pull request
Feb 24, 2026
Fixes bug introduced in #1870 where we were computing the mask after resetting the internal state of the guidance processor. Also fixes these issues: - Enables debug build when guidance is enabled. - Fixes bug where we log without checking if logging was enabled.
baijumeswani
added a commit
that referenced
this pull request
Feb 24, 2026
Fixes bug introduced in #1870 where we were computing the mask after resetting the internal state of the guidance processor. Also fixes these issues: - Enables debug build when guidance is enabled. - Fixes bug where we log without checking if logging was enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resets the guidance logits processor when generation is completed and fixes the last action that occurred.
Motivation and Context
This PR fixes a bug with providing grammars in multi-turn conversations where the generator is re-used.