Support RotaryEmbedding in GQA for webgpu ep #1847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qjia7
approved these changes
Oct 30, 2025
Contributor
qjia7
left a comment
qjia7
left a comment
There was a problem hiding this comment.
Add @kunal-vaishnavi review
kunal-vaishnavi
approved these changes
Oct 30, 2025
Contributor
|
onnxruntime / main supports this but no release does support this. |
Contributor
Is it better if we add a flag to enable RotaryEmbedding in GQA and set it to false by default? For the jsep path, it seems that we won't support it. So using a flag may be a solution. |
Contributor
Author
|
It seems that jsep support ROE in GQA. [WebGPU/JSEP] Support group query attention do_rotary attribute. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now onnxruntime have support GQA fused with RoPE, so we need to change the code to enable it by default.