Merged
Conversation
edgchen1
commented
Jun 3, 2025
edgchen1
commented
Jun 6, 2025
edgchen1
commented
Jun 6, 2025
Collaborator
|
Could you maybe post a snippet of what the output trace looks like and how it gets rendered through perfetto? |
Collaborator
|
Looks good. |
Contributor
Author
add [[nodiscard]] on DurationTrace ctors
baijumeswani
approved these changes
Jun 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Add some basic support for tracing. Currently, we can record durations in a timeline. This is useful for understanding how long different pieces of code take to run.
Tracing can be enabled with CMake build option ENABLE_TRACING.