Skip to content

Disable buffer sharing for config only #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kunal-vaishnavi merged 1 commit into from
Nov 1, 2024
Merged

Disable buffer sharing for config only #1028

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/python/py/models/builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ def make_genai_config(self, model_name_or_path, extra_kwargs, out_dir):
"no_repeat_ngram_size": config.no_repeat_ngram_size if hasattr(config, "no_repeat_ngram_size") else 0,
"num_beams": config.num_beams if hasattr(config, "num_beams") else 1,
"num_return_sequences": config.num_return_sequences if hasattr(config, "num_return_sequences") else 1,
"past_present_share_buffer": self.past_present_share_buffer,
"past_present_share_buffer": False if "config_only" in self.extra_options else self.past_present_share_buffer,
"repetition_penalty": config.repetition_penalty if hasattr(config, "repetition_penalty") else 1.0,
"temperature": config.temperature if hasattr(config, "temperature") else 1.0,
"top_k": 1,
Expand Down