Add special tokens flag to C API tokenizer #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 1, 2025 15:00
…sions into sayanshaw/add-special-tokens
wenbingl
approved these changes
May 2, 2025
RyanUnderhill
added a commit
to microsoft/onnxruntime-genai
that referenced
this pull request
May 2, 2025
Sets `add_special_tokens` from `OrtxTokenizeWithOptions` added in microsoft/onnxruntime-extensions#940 to false to solve chat template issue in GenAI with extra BOS tokens. See huggingface/transformers#37686 for more context. --------- Co-authored-by: Sayan Shaw <[email protected]> Co-authored-by: Ryan Hill <[email protected]>
RyanUnderhill
added a commit
to microsoft/onnxruntime-genai
that referenced
this pull request
May 6, 2025
Sets `add_special_tokens` from `OrtxTokenizeWithOptions` added in microsoft/onnxruntime-extensions#940 to false to solve chat template issue in GenAI with extra BOS tokens. See huggingface/transformers#37686 for more context. --------- Co-authored-by: Sayan Shaw <[email protected]> Co-authored-by: Ryan Hill <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
add_special_tokensto C API to solve chat template issue in GenAI with extra BOS tokens.See huggingface/transformers#37686 for more context.