This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
test: add file cache for node tests #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 3, 2019
hariharans29
approved these changes
Apr 10, 2019
ybrnathan
approved these changes
Apr 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduce a memory file cache for node tests.
There are several hundreds of node test cases in suite test. The current test runner behavior is to use
fetch()to request every.onnx.pbfiles (for models and inputs/outputs). This means a lot of HTTP requests, and it makes trouble when running tests in BrowserStack, which usually ends up with a timeout failure.This change introduce a filePath-to-fileContent in-memory map as a file cache. The file content is preloaded and cooked into
testdata.js, which reduces the request number significantly.