Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Oct 17, 2023

Summary of the Pull Request

What is this about?

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Oct 17, 2023

Codecov Report

Merging #3575 (9b5d5ad) into main (44c2c39) will decrease coverage by 0.05%.
Report is 3 commits behind head on main.
The diff coverage is 2.12%.

@@            Coverage Diff             @@
##             main    #3575      +/-   ##
==========================================
- Coverage   39.96%   39.92%   -0.05%     
==========================================
  Files         303      303              
  Lines       37635    37671      +36     
  Branches     1721     1723       +2     
==========================================
- Hits        15042    15041       -1     
- Misses      22274    22311      +37     
  Partials      319      319              
Files Coverage Δ
src/ApiService/ApiService/Functions/Jobs.cs 67.30% <100.00%> (+0.31%) ⬆️
src/ApiService/ApiService/Log.cs 15.64% <ø> (+0.34%) ⬆️
.../ApiService/ApiService/onefuzzlib/JobOperations.cs 9.89% <0.00%> (-0.11%) ⬇️
...nt/onefuzz-task/src/tasks/report/dotnet/generic.rs 28.03% <0.00%> (ø)
src/ApiService/ApiService/Program.cs 8.14% <0.00%> (-1.70%) ⬇️

... and 1 file with indirect coverage changes

@chkeita chkeita force-pushed the log_refactoring branch 3 times, most recently from 689ad1b to a5f42ab Compare October 18, 2023 21:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants