Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 19 additions & 15 deletions src/agent/coverage/src/record/windows.rs
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
use std::collections::BTreeMap;
use std::path::Path;

use anyhow::{anyhow, bail, Error, Result};
use anyhow::{anyhow, Error, Result};
use debuggable_module::debuginfo::{DebugInfo, Function};
use debuggable_module::load_module::LoadModule;
use debuggable_module::loader::Loader;
Expand Down Expand Up @@ -132,20 +132,24 @@ impl<'cache, 'data> WindowsRecorder<'cache, 'data> {
return Ok(());
}

let breakpoint = self.breakpoints.remove(id);

let Some(breakpoint) = breakpoint else {
let stack = dbg.get_current_stack()?;
bail!("stopped on dangling breakpoint, debuggee stack:\n{}", stack);
};

let coverage = self
.coverage
.modules
.get_mut(&breakpoint.module)
.ok_or_else(|| anyhow!("coverage not initialized for module: {}", breakpoint.module))?;

coverage.increment(breakpoint.offset);
match self.breakpoints.remove(id) {
Some(breakpoint) => {
let coverage = self
.coverage
.modules
.get_mut(&breakpoint.module)
.ok_or_else(|| {
anyhow!("coverage not initialized for module: {}", breakpoint.module)
})?;

coverage.increment(breakpoint.offset);
}
// ASAN can set breakpoints which we don't know about, meaning they're not in `self.breakpoints`
None => {
let stack = dbg.get_current_stack()?;
warn!("stopped on dangling breakpoint, debuggee stack:\n{}", stack);
}
}

Ok(())
}
Expand Down