Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?

Closes #2964

Info on Pull Request

What does this include?

  • Added support for maxPerPage in ORM
  • Rename GetMessage to GetMessages in NodeMessageOperations
  • Created a new GetMessage that only queries one message from the DB using the new maxPerPage
  • Add a test

Validation Steps Performed

How does someone test & validate?

Added a test + checkpr

@codecov-commenter
Copy link

Codecov Report

Merging #3016 (b5d2a12) into main (ace0ccc) will decrease coverage by 0.01%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #3016      +/-   ##
==========================================
- Coverage   29.02%   29.02%   -0.01%     
==========================================
  Files         304      304              
  Lines       36326    36327       +1     
==========================================
  Hits        10545    10545              
- Misses      25781    25782       +1     
Impacted Files Coverage Δ
...c/ApiService/ApiService/Functions/AgentCommands.cs 0.00% <0.00%> (ø)
...ice/ApiService/onefuzzlib/NodeMessageOperations.cs 58.33% <0.00%> (-2.54%) ⬇️
src/ApiService/ApiService/Functions/Node.cs 79.56% <100.00%> (ø)
src/ApiService/ApiService/onefuzzlib/orm/Orm.cs 59.89% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea enabled auto-merge (squash) April 12, 2023 20:25
@tevoinea tevoinea merged commit c105423 into microsoft:main Apr 12, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request May 4, 2023
@nharper285 nharper285 mentioned this pull request May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for maxPerPage in ORM

4 participants