Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@tevoinea
Copy link
Member

@tevoinea tevoinea commented Mar 7, 2023

Summary of the Pull Request

What is this about?

This is a re-attempt of #2910 which adds a 2 way IPC connection between the agent and the task, and also implements a graceful shutdown on top of that connection.

What is different this time is that the graceful shutdown is implicitly tied to the lifetime of the IPC connection. In other words, when the IPC connection drops and the task sees the disconnect, the task will gracefully shut down.

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Merging #2912 (39c9568) into main (a374939) will decrease coverage by 0.46%.
The diff coverage is 43.92%.

@@            Coverage Diff             @@
##             main    #2912      +/-   ##
==========================================
- Coverage   29.38%   28.93%   -0.46%     
==========================================
  Files         271      303      +32     
  Lines       30281    36131    +5850     
==========================================
+ Hits         8899    10455    +1556     
- Misses      21382    25676    +4294     
Impacted Files Coverage Δ
src/agent/onefuzz-agent/src/scheduler.rs 51.97% <0.00%> (-1.83%) ⬇️
src/agent/onefuzz-task/src/local/common.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/managed/cmd.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-task/src/tasks/config.rs 0.00% <ø> (ø)
src/agent/onefuzz-task/src/tasks/fuzz/generator.rs 0.00% <0.00%> (ø)
...rc/agent/onefuzz-task/src/tasks/fuzz/supervisor.rs 0.00% <0.00%> (ø)
src/agent/onefuzz/src/ipc.rs 0.00% <0.00%> (ø)
src/agent/onefuzz/src/lib.rs 100.00% <ø> (ø)
src/agent/onefuzz-agent/src/worker.rs 47.70% <30.39%> (-11.39%) ⬇️
src/agent/onefuzz-agent/src/worker/double.rs 86.36% <70.00%> (-13.64%) ⬇️
... and 1 more

... and 49 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tevoinea tevoinea requested review from Porges and chkeita March 9, 2023 18:30
Copy link
Contributor

@mgreisen mgreisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@tevoinea tevoinea enabled auto-merge (squash) March 10, 2023 17:13
@tevoinea tevoinea merged commit 49543cf into microsoft:main Mar 10, 2023
@mgreisen mgreisen mentioned this pull request Mar 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants