This repository was archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Ipc between agent and task #2912
Merged
tevoinea
merged 19 commits into
microsoft:main
from
tevoinea:tevoinea/IpcBetweenAgentAndTask
Mar 10, 2023
Merged
Ipc between agent and task #2912
tevoinea
merged 19 commits into
microsoft:main
from
tevoinea:tevoinea/IpcBetweenAgentAndTask
Mar 10, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inea/IpcBetweenAgentAndTask
Codecov Report
@@ Coverage Diff @@
## main #2912 +/- ##
==========================================
- Coverage 29.38% 28.93% -0.46%
==========================================
Files 271 303 +32
Lines 30281 36131 +5850
==========================================
+ Hits 8899 10455 +1556
- Misses 21382 25676 +4294
... and 49 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mgreisen
approved these changes
Mar 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
This is a re-attempt of #2910 which adds a 2 way IPC connection between the agent and the task, and also implements a graceful shutdown on top of that connection.
What is different this time is that the graceful shutdown is implicitly tied to the lifetime of the IPC connection. In other words, when the IPC connection drops and the task sees the disconnect, the task will gracefully shut down.