This repository was archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
[Bug Fix] Create Wrapper Function To Handle GUID Table Properties #2898
Merged
nharper285
merged 13 commits into
microsoft:main
from
nharper285:user/noharper/proxy-investigation
Mar 2, 2023
Merged
[Bug Fix] Create Wrapper Function To Handle GUID Table Properties #2898
nharper285
merged 13 commits into
microsoft:main
from
nharper285:user/noharper/proxy-investigation
Mar 2, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m/nharper285/onefuzz into user/noharper/proxy-investigation
Codecov Report
@@ Coverage Diff @@
## main #2898 +/- ##
==========================================
+ Coverage 26.40% 28.06% +1.65%
==========================================
Files 125 302 +177
Lines 13509 35811 +22302
==========================================
+ Hits 3567 10050 +6483
- Misses 9942 25761 +15819
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
approved these changes
Mar 1, 2023
mgreisen
reviewed
Mar 1, 2023
Member
|
Looking good 👍 |
Porges
approved these changes
Mar 2, 2023
Porges
reviewed
Mar 2, 2023
mgreisen
approved these changes
Mar 2, 2023
Contributor
mgreisen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
tevoinea
approved these changes
Mar 2, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
It was found that the
onefuzz debug [node | task | etc.]command was not properly working - users were not able to rdp into task vmss instances.The issue was due to how we were querying certain ORM tables. To resolve the issue, Ive created a wrapper functions that converts all
guidargument types tostring.PR Checklist
onefuzz debugnot returning proxy ip #2897Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?