Skip to content
This repository was archived by the owner on Nov 1, 2023. It is now read-only.

Conversation

@nharper285
Copy link
Contributor

Summary of the Pull Request

What is this about?
It was found that the onefuzz debug [node | task | etc.] command was not properly working - users were not able to rdp into task vmss instances.

The issue was due to how we were querying certain ORM tables. To resolve the issue, Ive created a wrapper functions that converts all guid argument types to string.

PR Checklist

  • Applies to work item: onefuzz debug not returning proxy ip #2897
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@codecov-commenter
Copy link

codecov-commenter commented Mar 1, 2023

Codecov Report

Merging #2898 (5b739fe) into main (e653f9b) will increase coverage by 1.65%.
The diff coverage is 36.66%.

@@            Coverage Diff             @@
##             main    #2898      +/-   ##
==========================================
+ Coverage   26.40%   28.06%   +1.65%     
==========================================
  Files         125      302     +177     
  Lines       13509    35811   +22302     
==========================================
+ Hits         3567    10050    +6483     
- Misses       9942    25761   +15819     
Impacted Files Coverage Δ
src/ApiService/ApiService/Functions/Proxy.cs 0.00% <ø> (ø)
...ApiService/ApiService/onefuzzlib/NodeOperations.cs 23.78% <0.00%> (ø)
...ce/ApiService/onefuzzlib/ProxyForwardOperations.cs 0.00% <0.00%> (ø)
...piService/ApiService/onefuzzlib/ProxyOperations.cs 0.00% <0.00%> (ø)
...ApiService/ApiService/onefuzzlib/VmssOperations.cs 0.00% <0.00%> (ø)
...rc/ApiService/ApiService/onefuzzlib/orm/Queries.cs 55.10% <64.70%> (+10.10%) ⬆️
...rc/agent/onefuzz-task/src/tasks/coverage/dotnet.rs 0.00% <0.00%> (ø)
src/agent/debuggable-module/src/windows.rs 0.00% <0.00%> (ø)
src/agent/onefuzz-agent/src/worker.rs 56.76% <0.00%> (ø)
...ent/onefuzz-task/src/local/libfuzzer_regression.rs 0.00% <0.00%> (ø)
... and 173 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Porges
Copy link
Member

Porges commented Mar 2, 2023

Looking good 👍

Copy link
Contributor

@mgreisen mgreisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nharper285 nharper285 merged commit 8a7a0b0 into microsoft:main Mar 2, 2023
@mgreisen mgreisen mentioned this pull request Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants