This repository was archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Validate scriban on new notifications #2834
Merged
tevoinea
merged 6 commits into
microsoft:main
from
tevoinea:tevoinea/ValidateSribanOnNewNotifications
Feb 15, 2023
Merged
Validate scriban on new notifications #2834
tevoinea
merged 6 commits into
microsoft:main
from
tevoinea:tevoinea/ValidateSribanOnNewNotifications
Feb 15, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2834 +/- ##
==========================================
- Coverage 29.87% 29.84% -0.03%
==========================================
Files 324 324
Lines 39062 39130 +68
==========================================
+ Hits 11671 11680 +9
- Misses 27391 27450 +59
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tevoinea
commented
Feb 15, 2023
src/ApiService/ApiService/onefuzzlib/notifications/JinjaTemplateAdapter.cs
Show resolved
Hide resolved
tevoinea
commented
Feb 15, 2023
src/ApiService/ApiService/onefuzzlib/notifications/JinjaTemplateAdapter.cs
Show resolved
Hide resolved
tevoinea
commented
Feb 15, 2023
src/ApiService/ApiService/onefuzzlib/notifications/JinjaTemplateAdapter.cs
Show resolved
Hide resolved
chkeita
reviewed
Feb 15, 2023
chkeita
approved these changes
Feb 15, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Closes #2837
We should validate notification configs at creation time that they can be safely rendered by scriban.