This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Fix notification logic #2751
Merged
Fix notification logic #2751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bug was preventing the rest of the NewFils logic to proceed if no notification was associated with the container
tevoinea
approved these changes
Jan 19, 2023
Codecov Report
@@ Coverage Diff @@
## main #2751 +/- ##
=======================================
Coverage 29.08% 29.08%
=======================================
Files 321 321
Lines 38462 38462
=======================================
Hits 11188 11188
Misses 27274 27274
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing logic was stopping the processing of a new file when no notification is configured on the container.
This prevented task from receiving new file notification