This repository was archived by the owner on Nov 1, 2023. It is now read-only.
Wrap fallible ORM functions in try/catch #2745
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2745 +/- ##
==========================================
- Coverage 29.09% 29.08% -0.01%
==========================================
Files 321 321
Lines 38440 38462 +22
==========================================
+ Hits 11185 11188 +3
- Misses 27255 27274 +19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chkeita
reviewed
Jan 18, 2023
chkeita
approved these changes
Jan 19, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Closes #2709
Info on Pull Request
What does this include?
RequestFailedExceptionin fallible ORM functionsBatchOperationsignature to better indicate the 'all-or-nothing' behavior - more infoValidation Steps Performed
How does someone test & validate?