This repository was archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 199
Remove use of unapproved crypto libraries #2423
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08e3133 to
e2f6cb6
Compare
45ef47b to
48ba67c
Compare
Codecov Report
@@ Coverage Diff @@
## main #2423 +/- ##
=======================================
Coverage 29.98% 29.98%
=======================================
Files 289 289
Lines 35504 35504
=======================================
Hits 10645 10645
Misses 24859 24859 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
6f2d3dc to
f54dd12
Compare
f54dd12 to
45945f7
Compare
Porges
commented
Oct 19, 2022
Porges
commented
Oct 19, 2022
Porges
commented
Oct 19, 2022
0e3b4be to
c7b03da
Compare
chkeita
approved these changes
Oct 19, 2022
mgreisen
approved these changes
Oct 19, 2022
c7b03da to
9abe496
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To comply with Microsoft security policies, we must use only approved crypto libraries.
Notably,
ringis not on the approved libraries list. We should use the platform crypto libraries instead. The official guidance is:Following these guidelines strictly would mean that we have to build distro/version specific binaries for Linux. Instead we have an exception which allows us to statically link against the OpenSSL 1.1.1 series, allowing us to have a (somewhat) portable binary.
OpenSSL 1.1.1. can be statically linked by switching to the
native-tls-vendoredfeature ofreqwest. (Verified by inspection thatringandrustlsare no longer inCargo.lockfiles.)So the result is:
It is up to us to ensure we keep up-to-date with OpenSSL issues and releases. The version can be checked by looking at the version of
openssl-srcthat we depend upon. Currently this is111.22.0+1.1.1q. This is the latest version; also check the Vulnerabilities page.Verified by inspection that
rustlsandringare no longer present inCargo.lock.Current dynamic library dependencies are: