This repository was archived by the owner on Nov 1, 2023. It is now read-only.
-
Couldn't load subscription status.
- Fork 199
Make ImageReference strongly-typed and checked up-front #2369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7fa5ba9 to
3d2a07d
Compare
|
Need to do some validation that shared images work as expected before merging. |
tevoinea
approved these changes
Sep 9, 2022
e9f2807 to
0a89ca9
Compare
0a89ca9 to
d060da8
Compare
Codecov Report
@@ Coverage Diff @@
## main #2369 +/- ##
==========================================
+ Coverage 28.93% 29.09% +0.15%
==========================================
Files 303 303
Lines 36133 36170 +37
==========================================
+ Hits 10455 10523 +68
+ Misses 25678 25647 -31
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tevoinea
reviewed
Mar 22, 2023
tevoinea
approved these changes
Mar 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImageReferenceinto its own type so it is validated early on in request submission time, and we don't end up with malformed IDs, etc.This addresses/closes #1464 for the C# port. Also fixes #2927 which was recently reported.
Manually verified, I can create scalesets with:
/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Compute/galleries/{}/images/{}/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Compute/galleries/{}/images/{}/versions/{}Canonical:0000-com-ubuntu-server-focal:20_04-lts:latest/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Compute/images/{}Not manually verified:
/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Compute/locations/{}/sharedGalleries/{}/images/{}/subscriptions/{}/resourceGroups/{}/providers/Microsoft.Compute/locations/{}/sharedGalleries/{}/images/{}/versions/{}