Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Typings in addition to TSD #768

Closed
kant2002 opened this issue Mar 26, 2016 · 1 comment · Fixed by #1028
Closed

Support Typings in addition to TSD #768

kant2002 opened this issue Mar 26, 2016 · 1 comment · Fixed by #1028
Assignees
@mjbvz
Labels
feature
Milestone
Future

Comments

@kant2002
Copy link
Contributor

I think it would be sensible to have multiple strategies here. Since not only TSD right now the package manager for typigns, and there also Typings project which has main and browser folder. If both folders would be included in the project, they break the build. right now Typings is use exclude property in the tsconfig.json file.
kant2002 referenced this issue Mar 26, 2016
@mousetraps
Merge pull request #757 from mjbvz/vs14u2-add-dts-files-to-project
d966849 
Vs14u2 add dts files to project
@mjbvz mjbvz added the feature label Mar 29, 2016
@mjbvz mjbvz added this to the Future milestone Mar 29, 2016
@mjbvz
Copy link
Contributor

mjbvz commented Mar 29, 2016

Thanks for the suggestion. Since TSD is deprecated, we probably will be looking to moving to typings using the --ambient flag sometime in the future.

@kant2002 kant2002 mentioned this issue Mar 31, 2016
Closed
mjbvz added a commit to mjbvz/nodejstools that referenced this issue Jun 13, 2016
@mjbvz
Replace Tsd with Typings for Automatic Typings Acquisition
49ef719 
**Bug**
We currently use TSD to acquire typings metadata for intellisense in VS2015. Tsd is now deprecated. We are also installing TSD globally.

**Fix**
Use typings instead of TSD. We now also install typings in `%localappdata%` instead of installing it as a global dependency.

closes microsoft#768
@mjbvz mjbvz mentioned this issue Jun 13, 2016
Merged
@mjbvz mjbvz self-assigned this Jun 13, 2016
@mjbvz mjbvz removed the in-progress label Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjbvz mjbvz

Labels
feature
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

Replace Tsd with Typings for Automatic Typings Acquisition mjbvz/nodejstools
2 participants
@kant2002 @mjbvz