Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port to NAPI #644

Merged
merged 10 commits into from
Jan 26, 2024
Merged

Port to NAPI #644

merged 10 commits into from
Jan 26, 2024

Commits on Dec 5, 2023

  1. Port to NAPI 

    The "5th pty bug" in #432 fixed also.
    @kkocdko
    kkocdko committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    5dbe674 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2023

  1. Fix help message in pty.cc

    @kkocdko
    kkocdko committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    e5028c0 View commit details
    Browse the repository at this point in the history

  2. Move NAPI deps to devDependencies in package.json

    @kkocdko
    kkocdko committed Dec 6, 2023
    Configuration menu
    Copy the full SHA
    c682e8e View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2024

  1. Apply most of deepak1556's suggestions

    @kkocdko
    kkocdko committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    67142f9 View commit details
    Browse the repository at this point in the history

  2. Fix winpty

    @kkocdko
    kkocdko committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    64478d6 View commit details
    Browse the repository at this point in the history

  3. Fix conpty missing CloseHandle

    @kkocdko
    kkocdko committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    02e27b4 View commit details
    Browse the repository at this point in the history

  4. Use unique_ptr to avoid gotos

    @kkocdko
    kkocdko committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    5bc82dd View commit details
    Browse the repository at this point in the history

  5. Why macos failed?

    @kkocdko
    kkocdko committed Jan 24, 2024
    Configuration menu
    Copy the full SHA
    bf4ac88 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. fix: ci and minor cleanups

    @deepak1556
    deepak1556 committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    27254dd View commit details
    Browse the repository at this point in the history

  2. fix build failed on windows

    @kkocdko
    kkocdko committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    8dfeacd View commit details
    Browse the repository at this point in the history