Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make _fd and _pty public #143

Closed
hexa00 opened this issue Sep 18, 2017 · 2 comments
Closed

Make _fd and _pty public #143

hexa00 opened this issue Sep 18, 2017 · 2 comments
Labels
enhancement help wanted Issues identified as good community contribution opportunities
Milestone

Comments

@hexa00
Copy link

hexa00 commented Sep 18, 2017

Hi,
I use node-pty open() to open a pty and then use termios to set options on it.

To use this termios needs an fd, however _fd is a protected property.

I would also like to send the pty name to another program so I would need _pty to be public too.

Could these be made public ? Or could there by public accessors to them?

Thanks!

@Tyriar
Copy link
Member

Tyriar commented Sep 26, 2017

👍 to add public getters for them. I think renaming pty to ptsName would probably be best as I believe pts is most correct:

@Tyriar Tyriar added help wanted Issues identified as good community contribution opportunities enhancement labels Sep 26, 2017
@paul-marechal
Copy link

Bump! I would also be interested in having those fields public :)

corwin-of-amber added a commit to corwin-of-amber/node-pty that referenced this issue Dec 14, 2021
Closes microsoft#143.
In accordance with the discussion in the issue thread.
@Tyriar Tyriar added this to the 1.0.0 milestone Dec 14, 2021
@Tyriar Tyriar closed this as completed in 97f2f27 Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted Issues identified as good community contribution opportunities
Projects
None yet
Development

No branches or pull requests

3 participants