Fix handle cleanup code (#626)

microsoft · Oct 4, 2023 · d6ce76a · d6ce76a
1 parent a5f1d72
commit d6ce76a
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/src/win/conpty.cc b/src/win/conpty.cc
@@ -257,6 +257,13 @@ static void OnProcessExit(uv_async_t *async) {
   DWORD exitCode = 0;
   GetExitCodeProcess(baton->hShell, &exitCode);
 
+  // Clean up handles
+  // Calling DisconnectNamedPipes here or in PtyKill results in a crash,
+  // ref https://github.com/microsoft/node-pty/issues/512,
+  // so we only call CloseHandle for now.
+  CloseHandle(baton->hIn);
+  CloseHandle(baton->hOut);
+
   // Call function
   v8::Local<v8::Value> args[1] = {
     Nan::New<v8::Number>(exitCode)
@@ -476,10 +483,6 @@ static NAN_METHOD(PtyKill) {
       }
     }
 
-    DisconnectNamedPipe(handle->hIn);
-    DisconnectNamedPipe(handle->hOut);
-    CloseHandle(handle->hIn);
-    CloseHandle(handle->hOut);
     CloseHandle(handle->hShell);
   }