-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.2.1 has a breaking change #85
Comments
ping @aeschli |
We want to move forward and not commit to be backward compatible. We currently compile against es2020 and for that you need Node 14. Is there maybe a packager that you can useto back-compile? |
@aeschli that’s now how semver works, and no, it’s not safe to transpile code one didn’t author. The proper way to move forward is a breaking change whenever you drop support for a node version. This position means this package is not semver-compliant. |
We actually switched to es2020 already for 3.2.0. This is documented in the [CHANGELOG}( https://github.com/microsoft/node-jsonc-parser/blob/main/CHANGELOG.md) Maybe what should have happend is to add an |
ok, that’s still a breaking change in v3.2.0. You have to bump the major when you drop any platform/engine. |
Specifically, it uses the
??
operator, which doesn't work in node 12 (and breaks eslint-plugin-import tests).It was added here: #81 (comment)
Please remove use of this operator and publish a v3.2.2?
(I'm happy to make a PR if that's needed)
The text was updated successfully, but these errors were encountered: