Support view/resume experiment from external folder #3870
Conversation
QuanluZhang
requested review from
ultmaster and
liuzhe-lz
and removed request for
ultmaster
nni/tools/nnictl/launcher.py
Outdated
| if not os.path.isdir(args.experiment_dir): | ||
| print_error('Path %s is not folder directory!' % args.experiment_dir) | ||
| exit(1) | ||
| experiment_id = os.path.basename(args.experiment_dir) |
There was a problem hiding this comment.
This might not work for ~/nni/foo/ (ends with slash). Please check.
And since the experiment ID is not included in logDir / experimentWorkingDirectory, I think the argument is a little stange.
There was a problem hiding this comment.
add validation logic.
There was a problem hiding this comment.
nnictl view -e /home/lz/nni-experiments/Su83qgOR/ cannot pass validation.
I think it's frustrating since bash will automatically add the tail space with tab completion.
Suggest use Path(experiment_dir).name to replace os.path.basement.
There was a problem hiding this comment.
sure, updated to Path(args.experiment_dir).name.
nni/tools/nnictl/nnictl.py
Outdated
| @@ -167,6 +167,12 @@ def parse_args(): | |||
| parser_load_experiment.add_argument('--searchSpacePath', '-s', required=False, help='the path of search space file for \ | |||
| loaded experiment, this path contains file name. Default in $codeDir/search_space.json') | |||
| parser_load_experiment.set_defaults(func=load_experiment) | |||
| #view an NNI experiment | |||
There was a problem hiding this comment.
I'm a little confused. Where is the old view? As far as I remembered, there has already been a view.
There was a problem hiding this comment.
Seems there are nnictl experiment view and nnictl view.
There was a problem hiding this comment.
That's really confusing. Why can't we merge these two?
There was a problem hiding this comment.
unity command into nnictl view
SparkSnail
changed the title
| @@ -166,6 +166,10 @@ nnictl resume | |||
| - False | |||
| - | |||
| - set foreground mode, print log content to terminal | |||
| * - --experiment_dir, -e | |||
| - False | |||
There was a problem hiding this comment.
The default value is None?
There was a problem hiding this comment.
Yes, nnictl view will not use --experiment_dir by default.
nnictl experiment delete